[Webkit-unassigned] [Bug 32597] Check one space before end of line comments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32597





--- Comment #9 from Fumitoshi Ukai <ukai at chromium.org>  2009-12-16 19:19:44 PST ---
(In reply to comment #8)
> (In reply to comment #6)
> 
> > Hmm, so we don't need use_webkit_styles() and should have webkit style defaults
> > in _DEFAULT_FILTERS?
> 
> You should update since check-webkit-style changed since your patch.
> 
> My thinking is that the webkit default filter rules formerly in
> use_webkit_styles() should move from cpp_style.py to the check-webkit-style
> executable, and they should be passed in as a parameter to a function in
> cpp_style.py.  That's the direction I'm moving in:

It sounds different direction as Eric and David said.
I think we'll remove use_webkit_styles() and make check-webkit-style act as the
same way as cpp_style.py by default.
If we pass filters in use_webkit_styles() from check-webkit-style to
cpp_style.py, then it means cpp_style.py works differently from
check-webkit-style unless we pass the same filters, doesn't it?

> 
> https://bugs.webkit.org/show_bug.cgi?id=32592
> 
> I also think we should phase out the _DEFAULT_FILTERS global variable (now
> called _DEFAULT_FILTER_RULES), but we can't do that quite yet since the unit
> tests use it if I remember right.

We use change semantics of some error categories and/or _DEFAULT_FILTERS, we
need to update unittest as well.
(That's why I preserved default error categories in cpp_style.py in the first
patch.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.