[Webkit-unassigned] [Bug 32597] Check one space before end of line comments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32597





--- Comment #7 from David Levin <levin at chromium.org>  2009-12-16 17:22:23 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > I don't see what the distinction is.  cpp_style.py is fully forked from its
> > original chromium/google origins, so I'm not sure why running cpp_style.py
> > should be different from running run-webkit-tests.
> 
> Hmm, so we don't need use_webkit_styles() and should have webkit style defaults
> in _DEFAULT_FILTERS?

Maybe so.

> Should we fix the code instead of adding new error categories?(e.g. fix
> whitespace/comments rather than adding whitespace/webkit_comments)

Yes. (That fix possibly could be just replacing it with what you did -- I
haven't had a chance to review but was planning to look later tonight -- along
with the worker/websocket patch).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.