[Webkit-unassigned] [Bug 24001] [GTK] Cache control APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24001


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44307|review?                     |review-
               Flag|                            |




--- Comment #16 from Gustavo Noronha (kov) <gns at gnome.org>  2009-12-04 06:23:01 PST ---
(From update of attachment 44307)
> @@ -2543,6 +2546,8 @@ static void webkit_web_view_settings_notify(WebKitWebSettings* webSettings, GPar
>          if (page)
>              page->setTabKeyCyclesThroughElements(g_value_get_boolean(&value));
>      }
> +    else if (name == g_intern_string("enable-page-cache"))
> +        settings->setUsesPageCache(g_value_get_boolean(&value));
>      else if (!g_object_class_find_property(G_OBJECT_GET_CLASS(webSettings), name))
>          g_warning("Unexpected setting '%s'", name);
>      g_value_unset(&value);

Like the bot already told us, this else if should be on the line with the }.
The variable name is fine, though, leave it as is. Aside from this, the patch
looks good, so I would say just fix this and reupload so we can set cq+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.