[Webkit-unassigned] [Bug 24001] [GTK] Cache control APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24001





--- Comment #17 from Xan Lopez <xan.lopez at gmail.com>  2009-12-04 06:55:01 PST ---
(In reply to comment #16)
> (From update of attachment 44307 [details])
> > @@ -2543,6 +2546,8 @@ static void webkit_web_view_settings_notify(WebKitWebSettings* webSettings, GPar
> >          if (page)
> >              page->setTabKeyCyclesThroughElements(g_value_get_boolean(&value));
> >      }
> > +    else if (name == g_intern_string("enable-page-cache"))
> > +        settings->setUsesPageCache(g_value_get_boolean(&value));
> >      else if (!g_object_class_find_property(G_OBJECT_GET_CLASS(webSettings), name))
> >          g_warning("Unexpected setting '%s'", name);
> >      g_value_unset(&value);
> 
> Like the bot already told us, this else if should be on the line with the }.
> The variable name is fine, though, leave it as is. Aside from this, the patch
> looks good, so I would say just fix this and reupload so we can set cq+.

Actually there's no reason to not use camel case in those variables (and I'm
sure we do that in other places). But it can go in a different patch.

+    * viewers. This setting only controls the Page Cache, note that
+    * the Page Cache is an end user feature that makes navigating the
+    * web much smoother, it is not a cache in the disk cache sense and
+    * it is not a cache in the traditional memory cache. Basically the
+    * Page Cache makes clicking the back button almost
+    * instantaneous. For details about the different types of caches
+    * and their purposes see:
+    * http://webkit.org/blog/427/webkit-page-cache-i-the-basics/

I think here you are making things a bit confusing by not quoting the page
completely. The page cache is a memory cache, but what the blog means is that
it's not a "memory cache" in the traditional sense where a resource is stored
in memory to be used by any page. I think I'd only say that this cache is
different than the disk-based or memory-based traditional resource caches, that
its point is to make going back and forth between pages much faster, and that
for more details you can see the mentioned link. Ideally in the future we'd
have a full explanation somewhere in our docs instead of in an external link.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.