[Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28019





--- Comment #9 from George Staikos <staikos at kde.org>  2009-08-10 08:06:43 PDT ---
(In reply to comment #8)
> (From update of attachment 34135 [details])
> Well, I don't know what this change is doing from the ChangeLog.  I assume
> you're trying to make it possible to run Database operations on the main
> thread?
> 
> Redirecting to a platform-specific header is generally never the right
> approach:
> #if PLATFORM(WINCE)
>  35 
>  36 #include "wince/DatabaseThreadWince.h"
>  37 
>  38 #else
> 
> The abstraction (whatever you're trying to do there) likely belongs at a
> different/higher level.  It would be bad, for example if 5 ports all had
> redirects there.

Your assumption is correct.  We are of the understanding that few if any will
actually want this.  If it's desired by others, I agree it should be
refactored.  In KDE we had a policy that something doesn't become an API until
at least 2 separate users of it exist, otherwise it's a special case.  I think
that's prudent for WebKit too.  I don't see the reason to burden the main code
until we have evidence that someone else wants to use it too.  Quite honestly,
it's a bit ugly to have a multithreaded and a singlethreaded version in the
same place so I'd rather bury this ugly one away.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.