[Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28019





--- Comment #10 from Yong Li <yong.li at torchmobile.com>  2009-08-10 08:11:32 PDT ---
(In reply to comment #8)
> (From update of attachment 34135 [details])
> Well, I don't know what this change is doing from the ChangeLog.  I assume
> you're trying to make it possible to run Database operations on the main
> thread?
> 
> Redirecting to a platform-specific header is generally never the right
> approach:
> #if PLATFORM(WINCE)
>  35 
>  36 #include "wince/DatabaseThreadWince.h"
>  37 
>  38 #else
> 
> The abstraction (whatever you're trying to do there) likely belongs at a
> different/higher level.  It would be bad, for example if 5 ports all had
> redirects there.

Platform-independent webkit code could always work with single-threaded
application. But the storage/database implemenation broke that. It forces using
multiple threads. But threading is expensive on some platforms or is unwanted
by some products.

Our patch is single-threaded solution. If other ports or products want use this
solution, we can change the name from "Wince" to "SingleThreaded".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.