[Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28019





--- Comment #8 from Eric Seidel <eric at webkit.org>  2009-08-10 07:58:43 PDT ---
(From update of attachment 34135)
Well, I don't know what this change is doing from the ChangeLog.  I assume
you're trying to make it possible to run Database operations on the main
thread?

Redirecting to a platform-specific header is generally never the right
approach:
#if PLATFORM(WINCE)
 35 
 36 #include "wince/DatabaseThreadWince.h"
 37 
 38 #else

The abstraction (whatever you're trying to do there) likely belongs at a
different/higher level.  It would be bad, for example if 5 ports all had
redirects there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.