[Webkit-unassigned] [Bug 28126] [Haiku] Adding SharedTimer to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28126





--- Comment #3 from Maxime Simon <simon.maxime at gmail.com>  2009-08-09 11:46:06 PDT ---
(In reply to comment #2)
> (From update of attachment 34412 [details])
> The compiler won't read your comments. :)
>  // Static instance
>  88 SharedTimerHaiku* getSharedTimerHaiku()
> you want that to say:
> static SharedTimerHaiku* sharedTimerHaiku()
> (we don't tend to use "get" in function names in WebCore.)
> 
> Oh, maybe you don't want it static...  Why is this needed outside of this
> function?
>  52     SharedTimerHaiku* getSharedTimerHaiku();

I think that the purpose of this function is to return a static instance of
SharedTimer.

> Also, why doesn't SharedTimerHaiku implement SharedTimer?
> 
> Why does SharedTimerHaiku need to *be* a BMessageFilter, can't it just have a
> BMessageFilter member if necessary?

I didn't implement this class, but it seems that it was designed to fit with
the Haiku messaging system. That's why SharedTimerHaiku needs to be a derivated
class of BMessageFilter (in Haiku there is a lot of hook functions to implement
when derivating a class).

After this I don't say that we should keep this as it. I will see how other
ports handle SharedTimer and see if we can make something more smooth and
light. :)

Regards,
Maxime

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.