[Webkit-unassigned] [Bug 28126] [Haiku] Adding SharedTimer to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28126


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34412|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-09 08:06:49 PDT ---
(From update of attachment 34412)
The compiler won't read your comments. :)
 // Static instance
 88 SharedTimerHaiku* getSharedTimerHaiku()
you want that to say:
static SharedTimerHaiku* sharedTimerHaiku()
(we don't tend to use "get" in function names in WebCore.)

Oh, maybe you don't want it static...  Why is this needed outside of this
function?
 52     SharedTimerHaiku* getSharedTimerHaiku();

Also, why doesn't SharedTimerHaiku implement SharedTimer?

Why does SharedTimerHaiku need to *be* a BMessageFilter, can't it just have a
BMessageFilter member if necessary?

r- because I'm not sure why you needed to diverge from other SharedTimer
implementations here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.