[Webkit-unassigned] [Bug 28126] [Haiku] Adding SharedTimer to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28126





--- Comment #4 from Ryan Leavengood <leavengood at gmail.com>  2009-08-09 13:07:16 PDT ---
I had implemented SharedTimerHaiku differently in my original code and this
version was created by Andrea Anzani. I'm not sure if my original would fit
better in WebKit but this version may be better in the sense of fitting in with
Haiku.

It might be worth looking back in the history on my subversion copy of my old
port to see what my original was like. I'm not sure if you have that checked
out Maxime, but it is here:

http://ryanleavengood.com/svn/repo/WebKit/trunk/

Unfortunately I don't see anyway to go back in the history in this dead simple
SVN HTTP interface. So you'll need a copy checked out. If this is too difficult
I could probably get a copy of my original SharedTimerHaiku pretty fast.

It might also be worthwhile to look at the commit history to see why Andrea
replaced my version with this one. I think it was to sort out some threading
issues.

Finally BMessageFilter can be used both directly by passing in a filter_hook
function and by subclassing. I think in this case using subclassing is better
to easily access the members for the timer function and shouldRun boolean.

http://www.haiku-os.org/legacy-docs/bebook/BMessageFilter.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.