[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16979





------- Comment #7 from aroben at apple.com  2008-01-23 09:19 PDT -------
(In reply to comment #6)
> I think there are benefits in sharing the code rather than forking it into a
> new port. WIN should probably be made to only the "native" parts of the Windows
> ports, which is a slight semantic change, but can be introduced incrementally
> without vast search and replace or build system changes.

(I'm not sure what "native" really means here. Is Cairo a "native" Win32
library? It doesn't seem to be any more so than CoreGraphics, for example. So
we'll probably need a more descriptive name than "native" for whatever this
port becomes.)

I'm not suggesting that we abandon all code sharing. But there are many places
in this patch where the entire body of a function is #ifdef'd, which I think is
much less readable than splitting the two versions of the function into
separate files. Places where only parts of a function body are #ifdef'd are
probably good candidates for refactoring, perhaps by splitting out the #ifdef'd
parts into a helper function.

> Which source files are you worried about, specifically?

For example, SearchPopupMenuWin.cpp is not really useful if you don't have CF,
as the entire implementation is based on it, so I don't see any benefit to
sharing this file with a port that doesn't use CF.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.