[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16979





------- Comment #6 from alp at atoker.com  2008-01-23 09:05 PDT -------
(In reply to comment #5)
> (From update of attachment 18613 [edit])
> I don't think it's so great to have all these #ifdefs within each "Win" file. I
> think we're taking "Win" too literally here -- it doesn't (and shouldn't) mean
> "any port building on Windows" (for example, Qt/win doesn't use these files).
> Right now "Win" means "the Windows port which depends on CG, CF, CFNetwork,
> etc.". Clearly "Win" is not a great name for this. We should try to come up
> with a better name for the current port and a good name for the port you're
> starting to create. Then we can separate the implementations into separate
> files for each port, instead of tossing all these #ifdefs in.

I don't think the conditionals hurt readability here, but obviously you spend
more time working with this code, so you may disagree.

I think there are benefits in sharing the code rather than forking it into a
new port. WIN should probably be made to only the "native" parts of the Windows
ports, which is a slight semantic change, but can be introduced incrementally
without vast search and replace or build system changes.

Which source files are you worried about, specifically?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.