[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16979





------- Comment #8 from alp at atoker.com  2008-01-23 09:45 PDT -------
(In reply to comment #7)
> (In reply to comment #6)
> > I think there are benefits in sharing the code rather than forking it into a
> > new port. WIN should probably be made to only the "native" parts of the Windows
> > ports, which is a slight semantic change, but can be introduced incrementally
> > without vast search and replace or build system changes.
> 
> (I'm not sure what "native" really means here. Is Cairo a "native" Win32

By "native", I mean the code that uses Win32 API directly, for example places
where we use GDI directly. I'm suggesting that WIN can refer to these bits.

Cairo or CG certainly don't fall into the "native" category -- they have their
own platform defines.

> > Which source files are you worried about, specifically?
> 
> For example, SearchPopupMenuWin.cpp is not really useful if you don't have CF,
> as the entire implementation is based on it, so I don't see any benefit to
> sharing this file with a port that doesn't use CF.
> 

Many of the *Win source files only use Win32 directly and aren't Apple-specific
at all, so it makes sense to continue to use Win as an umbrella port name here.

Files which are mostly Apple-Win should probably be given a new name. I'd
propose moving SearchPopupMenuWin.cpp to SearchPopupMenuAWin.cpp and creating a
new SearchPopupMenuWin.cpp that uses native Win32 (Cairo doesn't come into the
picture here) for now. I actually suspect there won't be all that many files
that need renaming to AWin.

My AWin proposal is just to get the debate going, you may have better ideas :-)

I think it'll become more clear how to elegantly split the code modules as the
port develops and starts to work.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.