[Webkit-unassigned] [Bug 20277] implement window.scrollByPages and window.scrollByLines

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20277


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23055|review?                     |review-
               Flag|                            |




------- Comment #6 from darin at apple.com  2008-08-30 19:20 PDT -------
(From update of attachment 23055)
 822     Document* doc = m_frame->document();
 823     ASSERT(doc);
 824     if (doc)
 825         doc->updateLayoutIgnorePendingStylesheets();

This part of the code also belongs inside FrameView.

I'm going to say review- so you can move that code at a minimum. But also,
please investigate making the platforms share the same logic moving by line and
page by keyboard as for these functions.

For example, the current definition of how far to scroll by a line or page on
Mac OS X is in the WebFrameView class in the methods
_verticalKeyboardScrollDistance and _verticalPageScrollDistance. That's the
same distance scrollByLines and scrollByPages should use.

Maybe we do want to delegate this question to the client, because it does seem
that the Mac OS X methods are doing things that are specific to the platform.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.