[Webkit-unassigned] [Bug 20277] implement window.scrollByPages and window.scrollByLines

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20277


arenevier at fdn.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23055|0                           |1
        is obsolete|                            |




------- Comment #7 from arenevier at fdn.fr  2008-08-31 05:58 PDT -------
Created an attachment (id=23085)
 --> (https://bugs.webkit.org/attachment.cgi?id=23085&action=view)
updated patch

> This part of the code also belongs inside FrameView.

Ok,
I've updated my patch.

To share code between scrollByLines, and keypress handlers, I've though about
two ways:

* with current patch, platform could call scrollByLines or scrollByPages
methods. I don't understand mac specific code, so I don't known if that would
be possible, but it seems at least possible for gtk, qt and win platforms. A
cast would be needed to use those method from scrollview implementations (in
ScrollView::wheelEvent for example). For those methods to be useful,
scrollByLines could take two arguments (x and y) to handle left and right
arrow. Therefore, I'll attach an alternative patch to add an second argument to
scrollByLines.

* or, scrollByLines/scrollByPages could be dispatched to platform specific
scrollView. Then each platform would implement those method, and refactor some
code if they need. So, I'll attach another alternative patch that dispatch
scrollByLines/scrollByPages to currently notImplemented scrollView methods.

Is one of those methods right, or is there a better way to do ?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.