[Webkit-unassigned] [Bug 20277] implement window.scrollByPages and window.scrollByLines

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20277





------- Comment #5 from darin at apple.com  2008-08-28 09:50 PDT -------
(In reply to comment #4)
> Problem with current patch is that scrollByLines is not coherent with hitting
> arrow key (ie: it does not scroll same number of pixels); also, scrollByPages
> is not coherent with hitting page down. If that's important, may be, DOMWindow
> could forward directly to platform ScrollView, and each platform would handle
> it their own way.

I think that is important.

But I think calling out to the platform is not the right design going forward.
The right way to do it is to put the line and page scrolling into WebCore so
it's shared cross-platform. I think the reason it's currently separate for each
platform is mostly historical -- it was in WebKit on Mac OS X and it was one of
the things we didn't move into WebCore.

If there are important platform differences we can give platforms control, but
I suspect the current differences are mostly arbitrary and not worth
preserving.

However, it's not necessary to do all these things at once. For now, forwarding
to the same code that handles keyboard scrolling on all the platforms would be
OK.

I don't like the idea, though, of introducing duplicate code now, so I'd prefer
that we do one of the things I mention above.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.