[Webkit-unassigned] [Bug 15960] View source mode displays the attributes after an attribute with an empty value incorrectly.

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15960





------- Comment #19 from mitz at webkit.org  2007-12-30 19:30 PDT -------
(From update of attachment 18076)
This patch is correct, but it leaves the code in poor shape. I think it would
be better to define the 'attr' variable outside the the for loop, then when you
see an 'a', assign the current attribute to 'attr' and increment 'currAttr'.
Then you won't need the assignment in the else clause (since 'attr' will have
been assigned before) and you won't need to start the counter at -1.

The regression test should not dump the render tree, but instead do a text
dump. This is accomplished by adding something like

<script>
    if (window.layoutTestController) {
        layoutTestController.dumpAsText();
        layoutTestController.dumpChildFramesAsText();
    }
</script>

to the test. layoutTestController is an interface DumpRenderTree provides to
tests to control its behavior.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.