[Webkit-unassigned] [Bug 15960] View source mode displays the attributes after an attribute with an empty value incorrectly.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 23 14:56:52 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=15960


anyang.ren at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18065|review?                     |
               Flag|                            |
  Attachment #18065|0                           |1
        is obsolete|                            |
  Attachment #18076|                            |review?
               Flag|                            |




------- Comment #18 from anyang.ren at gmail.com  2007-12-23 14:56 PDT -------
Created an attachment (id=18076)
 --> (http://bugs.webkit.org/attachment.cgi?id=18076&action=view)
Proposed patch v3

I figured out a better fix.  It's much easier to determine when
we start processing the next attribute than to determine when we're
done with the current attribute.  So whenever we see the guide
character 'a', signaling the beginning of an attribute, we increment
currAttr.

This requires initializing currAttr to -1 so that after the first
increment it starts at 0.  So I have to declare currAttr as 'int',
and have to add a static cast to unsigned when I compare it with
token->attrs->length(), an unsigned value.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list