[webkit-reviews] review granted: [Bug 234109] [GPU Process] [Filters] Move FEImage to the 'platform' directory : [Attachment 449745] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 23 10:59:48 PST 2022


Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 234109: [GPU Process] [Filters] Move FEImage to the 'platform' directory
https://bugs.webkit.org/show_bug.cgi?id=234109

Attachment 449745: Patch

https://bugs.webkit.org/attachment.cgi?id=449745&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 449745
  --> https://bugs.webkit.org/attachment.cgi?id=449745
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449745&action=review

> Source/WebCore/platform/graphics/filters/software/FEImageSoftwareApplier.h:34
> +class FEImageSoftwareApplier : public FilterEffectConcreteApplier<FEImage> {

final?

> Source/WebCore/platform/graphics/filters/software/FEImageSoftwareApplier.h:41
> +    bool apply(const Filter&, const FilterImageVector& inputs, FilterImage&
result) const override;

private? final?


More information about the webkit-reviews mailing list