[webkit-reviews] review granted: [Bug 235462] Add pixel tolerance to some compositing tests : [Attachment 449710] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 235462: Add pixel tolerance to some compositing tests
https://bugs.webkit.org/show_bug.cgi?id=235462

Attachment 449710: Patch

https://bugs.webkit.org/attachment.cgi?id=449710&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 449710
  --> https://bugs.webkit.org/attachment.cgi?id=449710
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449710&action=review

rs=me with a small set of clarifying questions

> LayoutTests/ChangeLog:8
> +	   Add pixel tolerance to tests whose output is slightly different when
accelerated drawing

What’s the rationale here? How much pixel tolerance is too much? Are there some
tests where adding pixel tolerance would be a bad idea? Is it a good practice
to add pixel tolerance needed only on iOS simulator with accelerated drawing as
a cross platform parameter? Is this a forever good decision, or would we want
to return and lower the tolerance later?