[webkit-reviews] review granted: [Bug 235462] Add pixel tolerance to some compositing tests : [Attachment 449710] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 23 11:10:03 PST 2022

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 235462: Add pixel tolerance to some compositing tests

Attachment 449710: Patch


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 449710
  --> https://bugs.webkit.org/attachment.cgi?id=449710

View in context: https://bugs.webkit.org/attachment.cgi?id=449710&action=review

rs=me with a small set of clarifying questions

> LayoutTests/ChangeLog:8
> +	   Add pixel tolerance to tests whose output is slightly different when
accelerated drawing

What’s the rationale here? How much pixel tolerance is too much? Are there some
tests where adding pixel tolerance would be a bad idea? Is it a good practice
to add pixel tolerance needed only on iOS simulator with accelerated drawing as
a cross platform parameter? Is this a forever good decision, or would we want
to return and lower the tolerance later?

More information about the webkit-reviews mailing list