[webkit-reviews] review granted: [Bug 235486] [GTK][a11y] Test accessibility/url-test.html fails with ATSPI : [Attachment 449746] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 23 10:58:30 PST 2022


Darin Adler <darin at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 235486: [GTK][a11y] Test accessibility/url-test.html fails with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=235486

Attachment 449746: Patch

https://bugs.webkit.org/attachment.cgi?id=449746&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 449746
  --> https://bugs.webkit.org/attachment.cgi?id=449746
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449746&action=review

>
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:138
7
> +	   auto index = stringURL.find("LayoutTests");

Not great that we have to hardcode the directory name here. I don’t think we do
that other places in the test runners.


More information about the webkit-reviews mailing list