[webkit-reviews] review granted: [Bug 203312] Implement the CSS exponent functions: pow(), sqrt(), hypot() : [Attachment 439694] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kevin Turner
<kevinturner at utexas.edu>'s request for review:
Bug 203312: Implement the CSS exponent functions: pow(), sqrt(), hypot()
https://bugs.webkit.org/show_bug.cgi?id=203312

Attachment 439694: Patch

https://bugs.webkit.org/attachment.cgi?id=439694&action=review




--- Comment #65 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 439694
  --> https://bugs.webkit.org/attachment.cgi?id=439694
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439694&action=review

Have we imported WPT? Normally we'd import those as failing, then a patch like
this would mark them as passing.

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:980
> +	   if (calcOperationNode.isHypotNode())

Not clear why hypot doesn't have the depth check.

> Source/WebCore/css/calc/CSSCalcOperationNode.h:76
> +    bool isIdentity() const { return m_children.size() == 1 && (m_operator
== CalcOperator::Min || m_operator == CalcOperator::Max); }

isIdentity() is a confusing name here, hiding the fact that this only applies
to min and max.