[webkit-reviews] review granted: [Bug 230648] [GPU Process] support rendering Apple Pay buttons : [Attachment 438987] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 230648: [GPU Process] support rendering Apple Pay buttons
https://bugs.webkit.org/show_bug.cgi?id=230648

Attachment 438987: Patch

https://bugs.webkit.org/attachment.cgi?id=438987&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 438987
  --> https://bugs.webkit.org/attachment.cgi?id=438987
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438987&action=review

>>> Source/WebCore/ChangeLog:16
>>> +	     not as secure as we'd like for use in the GPUProcess.
>> 
>> What about doing something like we do for DrawGlyphsRecorder and use a
CGContextDelegate to get the underlying draw calls and serialize those? (This
is of course assuming CGContextDelegate doesn't have dedicate DrawPDFPage
delegation, but I didn't think it did)?
> 
> Interesting!	I had no idea that existed =D  And yeah I dont see anything
related to PDF.
> 
> Frankly though I'm not really sure I have the time to investigate this right
now.  I'm happy to file a followup to investigate this further if I get a
chance in a few weeks.
> 
> The initial desire for this change is to just get this working in a
GPUProcess world, which I think this achieves.

We don't have a general purpose recorder, only drawglyphs, so I think this is
OK for now (you could imagine us having implemented the whole of GPUP that way
instead, but we did not).