[webkit-reviews] review granted: [Bug 231010] Cocoa GraphicsContextGLOpenGL should not be used by GraphicsContextGLCVANGLE : [Attachment 439747] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 231010: Cocoa GraphicsContextGLOpenGL should not be used by
GraphicsContextGLCVANGLE
https://bugs.webkit.org/show_bug.cgi?id=231010

Attachment 439747: Patch

https://bugs.webkit.org/attachment.cgi?id=439747&action=review




--- Comment #4 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 439747
  --> https://bugs.webkit.org/attachment.cgi?id=439747
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439747&action=review

Since the underlying ANGLE context relationships haven't changed - still
creating a separate shared context for video uploads, with the same parameters
- this looks good to me. Agree this is just a refactor. The win failure looks
like an unrelated flake. r+

> Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.h:37
> +void* createPbufferAndAttachIOSurface(EGLDisplay, EGLConfig, GLenum target,
EGLint usageHint, GLenum internalFormat, GLsizei width, GLsizei height, GLenum
type, IOSurfaceRef, GLuint plane);

Would it be helpful to put these two free functions in another namespace or as
static methods on a class, just to have a little better scoping?