[webkit-reviews] review granted: [Bug 230286] Web Inspector: Don't maintain a back-forward stack for `ContentBrowser`/`ContentViewContainer` when not necessary : [Attachment 438202] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 230286: Web Inspector: Don't maintain a back-forward stack for
`ContentBrowser`/`ContentViewContainer` when not necessary
https://bugs.webkit.org/show_bug.cgi?id=230286

Attachment 438202: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=438202&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 438202
  --> https://bugs.webkit.org/attachment.cgi?id=438202
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=438202&action=review

r=me, awesome stuff =D

> Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js:32
> +	       disableBackForwardButtons: true,

NIT: `disableBackForwardButtons` makes me think that it's gonna leave the
buttons where they are but just `.enabled = false`.  Perhaps
`hideBackFowardButtons` instead?

> Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js:33
> +	       disableBackForwardNavigation: true,

Does this tab also need to remember selection like the Graphics Tab, or am I
misremembering/mistaken?

> Source/WebInspectorUI/UserInterface/Views/NetworkDetailView.js:88
> +	   this._contentBrowser = new WI.ContentBrowser(element, this,
{disableBackForwardButtons: true, disableBackForwardNavigation: true,
contentViewNavigationItemsFlexItem, contentViewNavigationItemsGroup});

I feel like this may want to keep a back-forward list for the various alternate
representations of the resource's content (e.g. "Response" vs "Response
(JSON)").  Can you confirm?