[webkit-reviews] review granted: [Bug 230236] Implement network process crash recovery for BroadcastChannel : [Attachment 438247] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 15 11:20:33 PDT 2021

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 230236: Implement network process crash recovery for BroadcastChannel

Attachment 438247: Patch


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 438247
  --> https://bugs.webkit.org/attachment.cgi?id=438247

View in context: https://bugs.webkit.org/attachment.cgi?id=438247&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp:113
> +    for (auto& channelsPerOriginEntry : m_channelsPerOrigin) {
> +	   auto& origin = channelsPerOriginEntry.key;
> +	   auto& channelsForOrigin = channelsPerOriginEntry.value;

I believe we can write this with de-structuring and save many lines of code:

    for (auto& [origin, channelsForOrigin] : m_channelsPerOrigin) {

But I haven’t tried it. Seems like it would be better if it works.

More information about the webkit-reviews mailing list