[webkit-reviews] review granted: [Bug 230186] Web Inspector: `FrameDOMTreeContentView` may update after it has `closed` called, causing hangs on some webpages on reload : [Attachment 438203] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 230186: Web Inspector: `FrameDOMTreeContentView` may update after it has
`closed` called, causing hangs on some webpages on reload
https://bugs.webkit.org/show_bug.cgi?id=230186

Attachment 438203: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=438203&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 438203
  --> https://bugs.webkit.org/attachment.cgi?id=438203
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=438203&action=review

r=me

Ideally in the future I think it'd be nice to entirely get rid of the `closed`
concept, but until that day this is a good step in the right direction :)

> Source/WebInspectorUI/ChangeLog:10
> +	   DOM tree. to combat this, add a flag to `ContentView` to mark a
closed `ContentView` as such, and then return

s/to/To

> Source/WebInspectorUI/UserInterface/Views/ContentView.js:397
> +	   this._isClosed = true;

Please make sure that all subclasses call `super.closed()` so that we won't
miss any scenarios where something should be `isClosed` but isn't.

> Source/WebInspectorUI/UserInterface/Views/ContentView.js:402
> +    get isClosed() {
> +	   return this._isClosed;
>      }

Style: `{` on a separate line
Style: you can make this all on one line at the top of the `// Public` section
since it's a simple `get` (i.e. only returns a variable with the same name as
the `get`)

> Source/WebInspectorUI/UserInterface/Views/FrameDOMTreeContentView.js:65
> +	   if (this.isClosed)

I wonder how many other things could have something like this too ��