[webkit-reviews] review granted: [Bug 234050] Move SystemFontDatabaseCoreText to FontCache : [Attachment 446470] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 234050: Move SystemFontDatabaseCoreText to FontCache
https://bugs.webkit.org/show_bug.cgi?id=234050

Attachment 446470: Patch

https://bugs.webkit.org/attachment.cgi?id=446470&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 446470
  --> https://bugs.webkit.org/attachment.cgi?id=446470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446470&action=review

> Source/WebCore/platform/graphics/FontCache.h:226
> +    SystemFontDatabaseCoreText m_systemFontDatabaseCoreText;

Is this going to compile on the non-Apple ports?

> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:257
> +	   result.fontName = AtomString("system-ui",
AtomString::ConstructFromLiteral);

Don't we have a suffix that does this? Like "system-ui"_as or something?