[webkit-reviews] review granted: [Bug 234049] Move FontFamilySpecificationCoreText's fontMap to FontCache : [Attachment 446469] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 234049: Move FontFamilySpecificationCoreText's fontMap to FontCache
https://bugs.webkit.org/show_bug.cgi?id=234049

Attachment 446469: Patch

https://bugs.webkit.org/attachment.cgi?id=446469&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 446469
  --> https://bugs.webkit.org/attachment.cgi?id=446469
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446469&action=review

> Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm:51
> +    // FIXME: Should clear this on all workers.

I think some members on the team prefer for FIXMEs to have Bugzilla links

>
Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:-39
> -struct FontFamilySpecificationKey {

It's kind of sad that this has to live in a different file, far from its use.
This cache isn't really reusable, and FontFamilySpecificationCoreText.cpp is
already fairly focused and cohesive with this in it. Can you think of a way to
keep this code closer to its use?