[webkit-reviews] review granted: [Bug 234127] Implement AbortSignal.throwIfAborted : [Attachment 446731] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 15:15:47 PST 2021

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 234127: Implement AbortSignal.throwIfAborted

Attachment 446731: Patch


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 446731
  --> https://bugs.webkit.org/attachment.cgi?id=446731

View in context: https://bugs.webkit.org/attachment.cgi?id=446731&action=review

> Source/WebCore/dom/AbortSignal.cpp:124
> +    JSC::throwException(&lexicalGlobalObject, scope,

Don’t need to write JSC::throwException; argument-dependent lookup should work
unless AbortSignal has a member function named throwException.

The cast to JSC::JSValue seems really sad. I would probably add one more local

    JSC::JSValue reason = m_reason;

Just because assignment is less forceful than a static_cast. Another solution
would be to add a member function to JSValueInWrappedObject that returns the
value. Could be named value() or get(). And use that instead of the

More information about the webkit-reviews mailing list