[webkit-reviews] review granted: [Bug 233952] Update ANGLE changes.diff with new roll. : [Attachment 446233] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 233952: Update ANGLE changes.diff with new roll.
https://bugs.webkit.org/show_bug.cgi?id=233952

Attachment 446233: Patch

https://bugs.webkit.org/attachment.cgi?id=446233&action=review




--- Comment #5 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 446233
  --> https://bugs.webkit.org/attachment.cgi?id=446233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446233&action=review

This update looks fine to me - let's please work together to upstream as many
of the remaining changes as possible, as soon as possible. r+

> Source/ThirdParty/ANGLE/changes.diff:1782
> ++		if (metalDevice.depth24Stencil8PixelFormatSupported &&	       
		       
!display->getFeatures().forceD24S8AsUnsupported.enabled)

This and some of the other whitespace changes are a bit unfortunate. Can they
be cleaned up?