[webkit-reviews] review granted: [Bug 233961] Web Inspector: evaluateScriptForExtension() incorrectly unwraps internal errors : [Attachment 446299] Patch v1.0

[bugzilla-daemon at webkit.org]

Patrick Angle <pangle at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 233961: Web Inspector: evaluateScriptForExtension() incorrectly unwraps
internal errors
https://bugs.webkit.org/show_bug.cgi?id=233961

Attachment 446299: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=446299&action=review




--- Comment #3 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 446299
  --> https://bugs.webkit.org/attachment.cgi?id=446299
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=446299&action=review

r=me

> Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp:255
> +		   LOG(Inspector, "Internal error encountered while evaluating
upon the frontend: at %s:%d:%d: %s", exceptionDetails.sourceURL.utf8().data(),
exceptionDetails.lineNumber, exceptionDetails.columnNumber,
exceptionDetails.message.utf8().data());

Nit: Odd placement of the first colon IMO... s/`frontend: at`/`frontend at`