[webkit-reviews] review granted: [Bug 234025] [ANGLE] Code generation happens on each build and produces SCM diffs : [Attachment 446403] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 234025: [ANGLE] Code generation happens on each build and produces SCM
diffs
https://bugs.webkit.org/show_bug.cgi?id=234025

Attachment 446403: Patch

https://bugs.webkit.org/attachment.cgi?id=446403&action=review




--- Comment #3 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 446403
  --> https://bugs.webkit.org/attachment.cgi?id=446403
Patch

I'd imagine they need to be already checked into repo, as ANGLE doesn't run
scripts compile time.
I'd also imagine run_code_generation.py could and should be fixed so that the
output isn't nondeterministic.