[webkit-reviews] review granted: [Bug 228673] [GPU Process] RemoteImageBufferProxy::flushDrawingContextAsync() should always append FlushContext to its DisplayList : [Attachment 434683] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 10:09:50 PDT 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 228673: [GPU Process] RemoteImageBufferProxy::flushDrawingContextAsync()
should always append FlushContext to its DisplayList
https://bugs.webkit.org/show_bug.cgi?id=228673

Attachment 434683: Patch

https://bugs.webkit.org/attachment.cgi?id=434683&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 434683
  --> https://bugs.webkit.org/attachment.cgi?id=434683
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434683&action=review

Is there a reason why we don't just check
`!m_drawingContext.displayList().isEmpty()` in `flushDrawingContext()`?

> Source/WebKit/ChangeLog:15
> +	   the backend context is flushed. Also we need GPUProces to send the
DidFush

Nits - GPUProces => GPUProcess, DidFush => DidFlush


More information about the webkit-reviews mailing list