[webkit-reviews] review granted: [Bug 228676] [JSC] Yarr should use Bitmap instead of ByteVector for BoyerMoore search : [Attachment 434703] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 228676: [JSC] Yarr should use Bitmap instead of ByteVector for BoyerMoore
search
https://bugs.webkit.org/show_bug.cgi?id=228676

Attachment 434703: Patch

https://bugs.webkit.org/attachment.cgi?id=434703&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 434703
  --> https://bugs.webkit.org/attachment.cgi?id=434703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434703&action=review

> Source/JavaScriptCore/yarr/YarrJIT.cpp:2428
> +			       auto matched = branchTestBit64(NonZero, regT2,
regT0); // We can ignore upper bits since module-64 is performed.

module->modulo

The instruction itself performs modulo 64?