[webkit-reviews] review granted: [Bug 228635] Align implementation of PositionIterator::isCandidate() on Position::isCandidate() : [Attachment 434616] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 228635: Align implementation of PositionIterator::isCandidate() on
Position::isCandidate()
https://bugs.webkit.org/show_bug.cgi?id=228635

Attachment 434616: Patch

https://bugs.webkit.org/attachment.cgi?id=434616&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 434616
  --> https://bugs.webkit.org/attachment.cgi?id=434616
Patch

Seems like a good idea, and having no effect on any test is a mixed bag (is it
really an improvement if it’s not detectable?).

Can we do a further improvement and make most of this be shared code, too?