[webkit-reviews] review granted: [Bug 208529] Rename urlSelected to changeLocation : [Attachment 392310] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 9 00:14:59 PDT 2020


Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 208529: Rename urlSelected to changeLocation
https://bugs.webkit.org/show_bug.cgi?id=208529

Attachment 392310: Patch

https://bugs.webkit.org/attachment.cgi?id=392310&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 392310
  --> https://bugs.webkit.org/attachment.cgi?id=392310
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392310&action=review

> Source/WebCore/loader/FrameLoader.h:-132
> -    void changeLocation(FrameLoadRequest&&);

Was this just unused? I don’t see any cases of this in the patch.


More information about the webkit-reviews mailing list