[webkit-reviews] review granted: [Bug 197797] Tail calls are broken on ARM_THUMB2 and MIPS : [Attachment 392300] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 197797: Tail calls are broken on ARM_THUMB2 and MIPS
https://bugs.webkit.org/show_bug.cgi?id=197797

Attachment 392300: Patch

https://bugs.webkit.org/attachment.cgi?id=392300&action=review




--- Comment #33 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 392300
  --> https://bugs.webkit.org/attachment.cgi?id=392300
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392300&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   `prepareForTailCall` operation expects that header size + parameters
> +	   size is aligned with stack (alignment is 16-bytes for every
architecture).

Can we debug-assert it?