[webkit-reviews] review granted: [Bug 208708] @putByValDirect does not perform [[DefineOwnProperty]] correctly : [Attachment 393001] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 208708: @putByValDirect does not perform [[DefineOwnProperty]] correctly
https://bugs.webkit.org/show_bug.cgi?id=208708

Attachment 393001: Patch

https://bugs.webkit.org/attachment.cgi?id=393001&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 393001
  --> https://bugs.webkit.org/attachment.cgi?id=393001
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393001&action=review

r=me with ChangeLog change.

> Source/JavaScriptCore/ChangeLog:10
> +	   This change fixes @putByValDirect to perform [[DefineOwnProperty]]
per spec [1] while preserving
> +	   existing behavior for Arguments exotic objects (thus the checks
order in canDoFastPutDirectIndex),
> +	   aligning JSC with V8 and SpiderMonkey.

Can you describe what is changed in detail?