[webkit-reviews] review denied: [Bug 214354] Add handling of out of memory handling while adding a worklet module. : [Attachment 404342] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 15 11:37:56 PDT 2020
Keith Miller <keith_miller at apple.com> has denied review:
Bug 214354: Add handling of out of memory handling while adding a worklet
module.
https://bugs.webkit.org/show_bug.cgi?id=214354
Attachment 404342: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=404342&action=review
--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 404342
--> https://bugs.webkit.org/attachment.cgi?id=404342
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=404342&action=review
r=me too with nit.
> Source/JavaScriptCore/runtime/VM.cpp:473
> + else
> + RELEASE_ASSERT(bigInt);
Nit: I don't think this is needed and will probably be removed by the compiler.
More information about the webkit-reviews
mailing list