[webkit-reviews] review granted: [Bug 214331] Should represent `TextPlaceholderElement` as an `NSTextAttachmentCharacter` instead of a `\n` : [Attachment 404355] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 214331: Should represent `TextPlaceholderElement` as an
`NSTextAttachmentCharacter` instead of a `\n`
https://bugs.webkit.org/show_bug.cgi?id=214331

Attachment 404355: Patch

https://bugs.webkit.org/attachment.cgi?id=404355&action=review




--- Comment #10 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 404355
  --> https://bugs.webkit.org/attachment.cgi?id=404355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404355&action=review

> Source/WebCore/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * editing/TextIterator.cpp:

It would be nice to have a few words here to explain why we want to emit the
replacement character instead of a newline (something similar to what you
already wrote in the comment below).