[webkit-reviews] review requested: [Bug 214309] [webkitcorepy] Spin off general webkitpy tools into a pip module : [Attachment 404258] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 15 11:46:15 PDT 2020


Jonathan Bedard <jbedard at apple.com> has asked  for review:
Bug 214309: [webkitcorepy] Spin off general webkitpy tools into a pip module
https://bugs.webkit.org/show_bug.cgi?id=214309

Attachment 404258: Patch

https://bugs.webkit.org/attachment.cgi?id=404258&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 404258
  --> https://bugs.webkit.org/attachment.cgi?id=404258
Patch

The consensus I've heard so far is that this is the right direction.

Obviously a single class is insufficient for a library, but I think that doing
this piece-by-piece will result in cleaner SCM history as well as more thorough
code review.


More information about the webkit-reviews mailing list