[webkit-reviews] review granted: [Bug 195780] Make it possible to test scrolling tree layer manipulation more easily : [Attachment 364711] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 14 16:25:28 PDT 2019


Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 195780: Make it possible to test scrolling tree layer manipulation more
easily
https://bugs.webkit.org/show_bug.cgi?id=195780

Attachment 364711: Patch

https://bugs.webkit.org/attachment.cgi?id=364711&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 364711
  --> https://bugs.webkit.org/attachment.cgi?id=364711
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364711&action=review

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h:64
> + at property (nonatomic, setter=_setScrollingUpdatesDisabledForTesting:) BOOL
_scrollingUpdatesDisabledForTesting;

Shouldn't need this?

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:51
> +    BOOL m_scrollingUpdatesDisabled;

No m_ for ObjC ivars


More information about the webkit-reviews mailing list