[webkit-reviews] review denied: [Bug 195768] Web process is put to suspended when holding locked WebSQL files : [Attachment 364706] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 14 16:17:53 PDT 2019


Geoffrey Garen <ggaren at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 195768: Web process is put to suspended when holding locked WebSQL files
https://bugs.webkit.org/show_bug.cgi?id=195768

Attachment 364706: Patch

https://bugs.webkit.org/attachment.cgi?id=364706&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 364706
  --> https://bugs.webkit.org/attachment.cgi?id=364706
Patch

In file included from ./inspector/CommandLineAPIHost.cpp:34:
In file included from
/Volumes/Data/EWS/WebKit/Source/WebCore/Modules/webdatabase/Database.h:32:
/Volumes/Data/EWS/WebKit/Source/WebCore/platform/sql/SQLiteDatabase.h:159:28:
error: expected ';' at end of declaration list
    bool m_useWAL { false }


More information about the webkit-reviews mailing list