[webkit-reviews] review granted: [Bug 194806] IndexedDB: re-enable some leak tests : [Attachment 364667] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 14 16:27:44 PDT 2019
Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 194806: IndexedDB: re-enable some leak tests
https://bugs.webkit.org/show_bug.cgi?id=194806
Attachment 364667: Patch
https://bugs.webkit.org/attachment.cgi?id=364667&action=review
--- Comment #31 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 364667
--> https://bugs.webkit.org/attachment.cgi?id=364667
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=364667&action=review
r=me with two suggested fixes
> Source/WebCore/Modules/indexeddb/IDBRequest.cpp:155
> + if (!m_contextStopped)
> + clearWrappers();
I think you can remove this. Let's discuss.
> Source/WebCore/bindings/js/JSValueInWrappedObject.h:39
> + JSValueInWrappedObject(JSValueInWrappedObject&);
Should this be const JSValueInWrappedObject&? I don't think this is a copy
constructor if you forget the const.
More information about the webkit-reviews
mailing list