[webkit-reviews] review granted: [Bug 193054] Should expose other authors from same analysis task to finalize script. : [Attachment 358133] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 9 14:21:25 PST 2019
Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 193054: Should expose other authors from same analysis task to finalize
script.
https://bugs.webkit.org/show_bug.cgi?id=193054
Attachment 358133: Patch
https://bugs.webkit.org/attachment.cgi?id=358133&action=review
--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 358133
--> https://bugs.webkit.org/attachment.cgi?id=358133
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=358133&action=review
> Websites/perf.webkit.org/tools/js/analysis-results-notifier.js:53
> + const testGroupInfo = {author: testGroup.author(),
otherAuthorsFromSameTask: Array.from(otherAuthorsFromSameTask)};
This is a very verbose name... Why not just taskAuthors or authorsInTask?
More information about the webkit-reviews
mailing list