[webkit-reviews] review granted: [Bug 193292] Gigacage disabling checks should handle the GIGACAGE_ALLOCATION_CAN_FAIL case properly. : [Attachment 358729] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 193292: Gigacage disabling checks should handle the
GIGACAGE_ALLOCATION_CAN_FAIL case properly.
https://bugs.webkit.org/show_bug.cgi?id=193292

Attachment 358729: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=358729&action=review




--- Comment #2 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 358729
  --> https://bugs.webkit.org/attachment.cgi?id=358729
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=358729&action=review

r=me

> Source/bmalloc/bmalloc/Gigacage.cpp:218
> +	   if (!GIGACAGE_ALLOCATION_CAN_FAIL || wasEnabled())

This code clearly says that the following `function` will be expected to cause
the crash. So I think this `function` name should be renamed to `crash` or
something like this.