[webkit-reviews] review denied: [Bug 193292] Gigacage disabling checks should handle the GIGACAGE_ALLOCATION_CAN_FAIL case properly. : [Attachment 358729] proposed patch.

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied  review:
Bug 193292: Gigacage disabling checks should handle the
GIGACAGE_ALLOCATION_CAN_FAIL case properly.
https://bugs.webkit.org/show_bug.cgi?id=193292

Attachment 358729: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=358729&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 358729
  --> https://bugs.webkit.org/attachment.cgi?id=358729
proposed patch.

Oops, my fix is incorrect.  We are using addPrimitiveDisableCallback()
elsewhere to fire watchpoints if the Gigacage is disabled.  Hence, I do need to
call the callbacks.  Will update the fix and post a mew patch shortly.