[webkit-reviews] review granted: [Bug 189525] [IntersectionObserver] Implement rootMargin expansion : [Attachment 349467] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ali Juma
<ajuma at chromium.org>'s request for review:
Bug 189525: [IntersectionObserver] Implement rootMargin expansion
https://bugs.webkit.org/show_bug.cgi?id=189525

Attachment 349467: Patch

https://bugs.webkit.org/attachment.cgi?id=349467&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349467
  --> https://bugs.webkit.org/attachment.cgi?id=349467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349467&action=review

> Source/WebCore/dom/Document.cpp:7498
> +    localRootBounds.move(-rootMarginFloatBox.left(),
-rootMarginFloatBox.top());
> +    localRootBounds.expand(rootMarginFloatBox.left() +
rootMarginFloatBox.right(), rootMarginFloatBox.top() +
rootMarginFloatBox.bottom());

It feels like there should be a cleaner way to do this.