[webkit-reviews] review granted: [Bug 189478] Expose a few WebPlaybackControlsManager-driven PIP APIs to clients : [Attachment 349402] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Matt Rajca
<mrajca at apple.com>'s request for review:
Bug 189478: Expose a few WebPlaybackControlsManager-driven PIP APIs to clients
https://bugs.webkit.org/show_bug.cgi?id=189478

Attachment 349402: Patch

https://bugs.webkit.org/attachment.cgi?id=349402&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 349402
  --> https://bugs.webkit.org/attachment.cgi?id=349402
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349402&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:1226
> +bool WebViewImpl::isPictureInPictureActive()
> +{
> +    if (!m_playbackControlsManager)
> +	   return false;
> +
> +    return [m_playbackControlsManager isPictureInPictureActive];
> +}
> +
> +void WebViewImpl::togglePictureInPicture()
> +{
> +    [m_playbackControlsManager togglePictureInPicture];
> +}

Nit: do you need to NULL-test m_playbackControlsManager in one method but not
the other?